[config reload] Removed replace irreversibly job-mode for sonic.target restart #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy Karri <[email protected]>
|
@stepanblyschak , @nazariig, @rajendra-dendukuri, @qiluo-msft Please review |
|
Required for 202012 |
nazariig
approved these changes
Sep 14, 2021
stepanblyschak
approved these changes
Sep 14, 2021
qiluo-msft
approved these changes
Sep 15, 2021
|
Do you need it on 202106 branch? |
Yes |
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 15, 2021
#### What I did As discussed in this PR #1814 (comment), only the stop.job should have job-mode set to replace irreversibly. Otherwise, simultaneous config reloads in the quick succession, can lead to the behavior. Although ,when the restart job (and all the other dependent jobs) are finished and is taken out of systemd's job queue, the next stop job will not be cancelled.
judyjoseph
pushed a commit
that referenced
this pull request
Sep 27, 2021
#### What I did As discussed in this PR #1814 (comment), only the stop.job should have job-mode set to replace irreversibly. Otherwise, simultaneous config reloads in the quick succession, can lead to the behavior. Although ,when the restart job (and all the other dependent jobs) are finished and is taken out of systemd's job queue, the next stop job will not be cancelled.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Included Commits 92d0744 [config reload] Removed job-mode for sonic.target restart (sonic-net#1820) c28fb22 [ci]: Support PR coverage (sonic-net#1806)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vivek Reddy Karri [email protected]
What I did
As discussed in this PR #1814 (comment), only the stop.job should have job-mode set to replace irreversibly.
Otherwise, simultaneous config reloads in the quick succession, can lead to the behavior.
Although ,when the restart job (and all the other dependent jobs) are finished and is taken out of systemd's job queue, the next stop job will not be cancelled.
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)